gh-152785: Upgrade Ubuntu from 24.04 to 26.04 in GitHub Actions#152717
Open
vstinner wants to merge 7 commits into
Open
gh-152785: Upgrade Ubuntu from 24.04 to 26.04 in GitHub Actions#152717vstinner wants to merge 7 commits into
vstinner wants to merge 7 commits into
Conversation
Member
Author
|
"Check if generated files are up to date" job:
Later in the same job, |
Member
Author
|
(*) Address sanitizer (ubuntu-26.04): "Set up GCC-10 for ASAN" fails with (*) llvm.sh fails with
(*) Android (x86_64) fails with: |
Member
Author
It complains because it doesn't know |
Member
Author
|
Information on |
Member
Author
The job requires GCC 10 because in 2023, Ubuntu provided GCC 9 by default which had a bug with vfork(). This is no longer needed on Ubuntu 26.04. |
Member
Author
|
I modified Platforms/Android to run gradlew with Full error: DetailsSee yairm210/Unciv#14838 which seems to be similar. |
Member
Author
|
See https://github.com/orgs/community/discussions/160592 to select the JAVA_HOME env var. |
Member
Author
|
Summary:
|
vstinner
changed the title
hugovk
reviewed
Jul 1, 2026
Member
Author
|
This PR changes multiple things at once. I created other PRs to upgrade LLVM, GCC and Java to prepare this PR. See pull requests attached to #152785. |
hugovk
changed the title
Member
|
Probably, with 26.04 you can remove libmpdec workaround from |
…ctions Update .github/actionlint.yaml to allow ubuntu-26.04 and ubuntu-26.04-arm images.
No longer install build+install libmpdec-dev from tarball.
ubuntu-latest is currently Ubuntu 24.04.
Member
Author
|
Currently, ubuntu-latest means Ubuntu 24.04. So I replaced @hugovk: Do we want to keep |
Member
Author
|
Ubuntu / build and test (ubuntu-24.04) => Ubuntu / build and test (ubuntu-26.04). Before => After:
|
The ubuntu-26.04 image already provides required LLVM 21.
vstinner
changed the title
vstinner
requested review from
a team,
ezio-melotti,
markshannon and
savannahostrowski
as code owners
vstinner
requested review from
AA-Turner,
JacobCoffee,
itamaro and
webknjaz
as code owners
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest |
Member
There was a problem hiding this comment.
I don't think we need to change these, they don't rely on the version of the underlying system. Less maintenance burden if they are unpinned.
Member
Author
There was a problem hiding this comment.
See my question about that in my previous comment: #152717 (comment).
Member
There was a problem hiding this comment.
The lint jobs, docs and libexpat checks don't rely on system tools, I don't think there is a significant risk of updates causing us any issues. Hugo, WDYT?
Member
Generally, in this repo, pinning explicitly makes sense for the workflows that do stuff like build/test CPython. For the workflows like In fact, there's a new |
hugovk
reviewed
Jul 3, 2026
Member
|
I'm definitely in favor of using |
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
ubuntu-24.04andubuntu-latestwithubuntu-26.04.Update
.github/actionlint.yamlto allowubuntu-26.04andubuntu-26.04-armimages.Install Ubuntu
libmpdec-devpackage, rather than installlibmpdecfrom a tarball.No longer run
https://apt.llvm.org/llvm.sh, since ubuntu-26.04 provides clang-21 by default.Touch
Python/getcompiler.candPython/bytecodes.cto trigger most GHA jobs.This change will be reverted once the PR is reviewed and ready to be merged.